search

mapaction / mapaction-toolbox

A collection of tools to help streamline the process of producing maps including data renaming and map exports.
GNU General Public License v3.0
3 stars 1 forks source link

browsing to old config files causes unhandled exception #61

Open stringfellow opened 10 years ago

stringfellow commented 10 years ago

From gd...@mapaction.org on July 30, 2013 12:02:19

What steps will reproduce the problem? 1.In the config tool, browsing to a folder containing an old operation_config.xml file causes an unhandled exception to occur 2.old file attached for testing 3. What is the expected output? What do you see instead? should report it as an old version of the file to be deleted before proceeding or open it Please use labels and text to provide additional information.

Attachment: operation_config.xml

Original issue: http://code.google.com/p/mapaction-toolbox/issues/detail?id=61

stringfellow commented 10 years ago

From andrewphilipsmith on August 17, 2013 03:54:26

I've not had a chance to test this yet, just look at the example operation_config.xml file. I think that this is due to the way teh path is stored in the file - as a windows path (eg D:\mapaction) with a drive letter and backslashes. This is not valid XML as far as I'm aware. it should be converted to a file:/// url first. See this post: http://stackoverflow.com/questions/758605/producing-a-windows-path-from-an-xml-uri And the PathCreateFromUrl and UrlCreateFromPath functions.

Once I tested it I'll assign it to Chris (if that's OK).

Cc: ewingch...@gmail.com
Blockedon: mapaction-toolbox:35 mapaction-toolbox:39 mapaction-toolbox:43 mapaction-toolbox:56

stringfellow commented 10 years ago

From andrewphilipsmith on August 29, 2013 16:51:46

This was related to the way the path is stored as a Windows path, not a URI. The MapAction.Utilites class has been updated to write the export path as local URI (eg file:///some/path/) when writing to the operation_config.xml. This is then re-interpreated as a local path (eg D:\MapAction\my\crash\move\folder) when the operation_config.xml file is read.

Status: Fixed

stringfellow commented 10 years ago

From gd...@mapaction.org on August 16, 2014 08:52:19

still creates an unhandled exception when the config file contains an export path in the wrong format i.e D:\mapaction Once updated, the file behaves correctly as the path is correctly stored as a url.

Status: Started