mapaction / osm2mapaction

Conversion of OSM data to the MapAction Data Naming Convention
GNU General Public License v3.0
6 stars 3 forks source link

a particularly anal PEP8 go through, and some little tweaks #5

Closed stringfellow closed 9 years ago

stringfellow commented 9 years ago

@andrewphilipsmith I've gone through this in vim with pylint and pyflakes on, and kept resolving things until the little quickfix window vanishes (that's my litmus test). Also simplified a couple of bits (removed reduce in favour of using string.join), and added some notes (there's a possible vulnerability in the aggregator, though I guess it probably doesn't "matter" since it's in-memory, but may cause errors anyway).

Haven't tested this yet, so this was a pure code-reading exercise!

(Sorry - recreated as I didn't want to PR into master)