search

mapado / datection

Detect and normalize temporal expressions
0 stars 0 forks source link

fix for exclusion timepoint generating unicode has no attribute span error #11

Closed jdeniau closed 4 years ago

jdeniau commented 9 years ago

Pull request :twisted_rightwards_arrows: created by @jnieuviarts on 2015-06-22 11:38 Last updated on 2015-06-23 15:28 Original Bitbucket pull request id: 11

Participants:

  • bitbucket user dream (reviewer) :heavy_check_mark:
  • a former bitbucket user (account deleted)
  • @jdeniau (reviewer)
  • @dallegoet (reviewer) :heavy_check_mark:

Source: https://github.com/mapado/datection/commit/f5ab7c1481fc on branch is_exclusion_timepoint_fix Destination: https://github.com/mapado/datection/commit/5952c6704a8a on branch master Merge commit: https://github.com/mapado/datection/commit/22dd4bd08b30

State: MERGED

jdeniau commented 9 years ago

A former bitbucket user (account deleted) commented on 2015-06-22 11:39

[BuildFinished datection_pullrequests] f5ab7c1481fc into 5952c6704a8a

? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/1/

jdeniau commented 9 years ago

@jdeniau commented on 2015-06-22 12:23

Est-ce que tu peux ajouter un test avec le cas qui plantait (et qui du coup ne plante plus) pour qu'on comprenne exactement ce que fait ce code ?

jdeniau commented 9 years ago

Bitbucket user dream approved :heavy_check_mark: the pull request on 2015-06-22 14:25

jdeniau commented 9 years ago

@dallegoet approved :heavy_check_mark: the pull request on 2015-06-23 07:55