search

mapado / datection

Detect and normalize temporal expressions
0 stars 0 forks source link

Add_point_as_date_sep #13

Closed jdeniau closed 4 years ago

jdeniau commented 9 years ago

Pull request :twisted_rightwards_arrows: created by @jnieuviarts on 2015-07-07 14:43 Last updated on 2015-07-08 08:59 Original Bitbucket pull request id: 13

Participants:

  • bitbucket user dream (reviewer) :heavy_check_mark:
  • a former bitbucket user (account deleted)
  • @jdeniau (reviewer) :heavy_check_mark:
  • @Nickinthebox :heavy_check_mark:
  • @dallegoet (reviewer) :heavy_check_mark:

Source: https://github.com/mapado/datection/commit/ccae810f2e50 on branch add_point_as_date_sep Destination: https://github.com/mapado/datection/commit/a9c0303f2dd0 on branch master Merge commit: https://github.com/mapado/datection/commit/318e68def1b7

State: MERGED

PS : les mêmes tests plantent avant et sans ma modif, j'en deduis que ça passe et qu'on a toujours à faire au bug de certains tests sur datection. Par acquis de conscience, si Julien B, tu peux lancer les tests sur ta machine pour voir qu'ils passent tous, c'est top.

jdeniau commented 9 years ago

A former bitbucket user (account deleted) commented on 2015-07-07 14:43

[BuildFinished datection_pullrequests] ccae810f2e50 into 736871a9cb0c

? FAILURE - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/8/

jdeniau commented 9 years ago

@Nickinthebox approved :heavy_check_mark: the pull request on 2015-07-07 14:51

jdeniau commented 9 years ago

@jdeniau commented on 2015-07-08 06:50

test this please

jdeniau commented 9 years ago

A former bitbucket user (account deleted) commented on 2015-07-08 06:50

[BuildFinished datection_pullrequests] ccae810f2e50 into 736871a9cb0c

? FAILURE - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/9/

jdeniau commented 9 years ago

@jdeniau commented on 2015-07-08 06:56

Impossible a comprendre: aucun test ne fail sur vader, ni même en étant user jenkins sur jabba dans le même workspace ! 

::sh
ssh devteam@jabba.mapado.com
sudo -i -u jenkins
cd /home/jenkins/datection_pullrequests/workspace
.env/bin/py.test

# .............
# 420 passed in 2.64 seconds
jdeniau commented 9 years ago

@jdeniau approved :heavy_check_mark: the pull request on 2015-07-08 06:57

jdeniau commented 9 years ago

Bitbucket user dream approved :heavy_check_mark: the pull request on 2015-07-08 07:36

jdeniau commented 9 years ago

@dallegoet approved :heavy_check_mark: the pull request on 2015-07-08 08:02