Closed jdeniau closed 4 years ago
A former bitbucket user (account deleted) commented on 2015-08-26 12:52
[BuildFinished datection_pullrequests] a37700b196e3 into 026b26770cf7
? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/16/
Bitbucket user dream commented on 2015-08-26 13:00
Outdated location: line 601 of
datection/render.py
le début de ta condition est inutile utilise plutôt: if kwargs.get('include_dayname')
Bitbucket user dream commented on 2015-08-26 13:02
Outdated location: line 603 of
datection/render.py
pourquoi clear() apres le copy ?
Bitbucket user dream commented on 2015-08-26 13:06
Outdated location: line 1270 of
datection/render.py
le if me semble inutile puisque suivit d'un "for in"
Bitbucket user dream commented on 2015-08-26 13:06
Outdated location: line 642 of
datection/render.py
le début de ta condition est inutile utilise plutôt: if kwargs.get('include_dayname')
@zwit commented on 2015-08-26 13:07
Location:
datection/render.py
le if me semble inutile puisque suivit d'un "for in"
oui, j'avais pas le for avant^^' je change ça
Bitbucket user dream commented on 2015-08-26 13:08
Outdated location: line 643 of
datection/render.py
les 3 lignes précédente peuvent être remplacé par: include_dayname = kwargs.get('include_dayname')
Bitbucket user dream commented on 2015-08-26 13:08
Outdated location: line 1269 of
datection/render.py
point virgule
A former bitbucket user (account deleted) commented on 2015-08-26 13:15
[BuildFinished datection_pullrequests] 3560ab537c01 into 026b26770cf7
? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/17/
A former bitbucket user (account deleted) commented on 2015-08-26 13:17
[BuildFinished datection_pullrequests] fb7ffcad1c19 into 026b26770cf7
? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/18/
Bitbucket user dream commented on 2015-08-26 13:24
Outdated location: line 1274 of
datection/render.py
parenthese
Bitbucket user dream commented on 2015-08-26 13:25
Outdated location: line 1277 of
datection/render.py
pourquoi ce "if else" ne serait ce pas plutot nbdates += len(timespan)
Bitbucket user dream commented on 2015-08-26 13:26
Outdated location: line 1267 of
datection/render.py
parentheses
Bitbucket user dream commented on 2015-08-26 13:31
Outdated location: line 1272 of
datection/render.py
if inutile
A former bitbucket user (account deleted) commented on 2015-08-26 13:35
[BuildFinished datection_pullrequests] 85c454253dc0 into 026b26770cf7
? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/19/
A former bitbucket user (account deleted) commented on 2015-08-27 14:29
[BuildFinished datection_pullrequests] 85c454253dc0 into 026b26770cf7
? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/20/
Bitbucket user dream approved :heavy_check_mark: the pull request on 2015-08-28 08:04
A former bitbucket user (account deleted) commented on 2015-08-28 14:58
[BuildFinished datection_pullrequests] 85c454253dc0 into 026b26770cf7
? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/21/
@jdeniau approved :heavy_check_mark: the pull request on 2015-08-31 07:04