search

mapado / datection

Detect and normalize temporal expressions
0 stars 0 forks source link

add dayname if there is one or two dates #17

Closed jdeniau closed 4 years ago

jdeniau commented 9 years ago

Pull request :twisted_rightwards_arrows: created by @zwit on 2015-08-26 12:52 Last updated on 2015-08-31 07:32 Original Bitbucket pull request id: 17

Participants:

  • a former bitbucket user (account deleted)
  • @jdeniau :heavy_check_mark:
  • @zwit
  • bitbucket user dream (reviewer) :heavy_check_mark:

Source: https://github.com/mapado/datection/commit/85c454253dc0 on branch jp-fix-adddayname Destination: https://github.com/mapado/datection/commit/026b26770cf7 on branch master Merge commit: https://github.com/mapado/datection/commit/4a1673f4cbb9

State: MERGED

jdeniau commented 9 years ago

A former bitbucket user (account deleted) commented on 2015-08-26 12:52

[BuildFinished datection_pullrequests] a37700b196e3 into 026b26770cf7

? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/16/

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:00

Outdated location: line 601 of datection/render.py

le début de ta condition est inutile utilise plutôt: if kwargs.get('include_dayname')

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:02

Outdated location: line 603 of datection/render.py

pourquoi clear() apres le copy ?

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:06

Outdated location: line 1270 of datection/render.py

le if me semble inutile puisque suivit d'un "for in"

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:06

Outdated location: line 642 of datection/render.py

le début de ta condition est inutile utilise plutôt: if kwargs.get('include_dayname')

jdeniau commented 9 years ago

@zwit commented on 2015-08-26 13:07

Location: datection/render.py

le if me semble inutile puisque suivit d'un "for in"

oui, j'avais pas le for avant^^' je change ça

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:08

Outdated location: line 643 of datection/render.py

les 3 lignes précédente peuvent être remplacé par: include_dayname = kwargs.get('include_dayname')

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:08

Outdated location: line 1269 of datection/render.py

point virgule

jdeniau commented 9 years ago

A former bitbucket user (account deleted) commented on 2015-08-26 13:15

[BuildFinished datection_pullrequests] 3560ab537c01 into 026b26770cf7

? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/17/

jdeniau commented 9 years ago

A former bitbucket user (account deleted) commented on 2015-08-26 13:17

[BuildFinished datection_pullrequests] fb7ffcad1c19 into 026b26770cf7

? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/18/

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:24

Outdated location: line 1274 of datection/render.py

parenthese

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:25

Outdated location: line 1277 of datection/render.py

pourquoi ce "if else" ne serait ce pas plutot nbdates += len(timespan)

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:26

Outdated location: line 1267 of datection/render.py

parentheses

jdeniau commented 9 years ago

Bitbucket user dream commented on 2015-08-26 13:31

Outdated location: line 1272 of datection/render.py

if inutile

jdeniau commented 9 years ago

A former bitbucket user (account deleted) commented on 2015-08-26 13:35

[BuildFinished datection_pullrequests] 85c454253dc0 into 026b26770cf7

? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/19/

jdeniau commented 9 years ago

A former bitbucket user (account deleted) commented on 2015-08-27 14:29

[BuildFinished datection_pullrequests] 85c454253dc0 into 026b26770cf7

? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/20/

jdeniau commented 9 years ago

Bitbucket user dream approved :heavy_check_mark: the pull request on 2015-08-28 08:04

jdeniau commented 9 years ago

A former bitbucket user (account deleted) commented on 2015-08-28 14:58

[BuildFinished datection_pullrequests] 85c454253dc0 into 026b26770cf7

? SUCCESS - http://jenkins.mapado.com:81/jenkins/job/datection_pullrequests/21/

jdeniau commented 9 years ago

@jdeniau approved :heavy_check_mark: the pull request on 2015-08-31 07:04