search

mapado / datection

Detect and normalize temporal expressions
0 stars 0 forks source link

When time boundaries are missing in the exception rrules, use the boundaries of the main rrule #40

Closed jdeniau closed 4 years ago

jdeniau commented 7 years ago

Pull request :twisted_rightwards_arrows: created by @RomainMapado on 2016-12-29 16:29 Last updated on 2017-01-10 08:59 Original Bitbucket pull request id: 40

Participants:

  • @jdeniau (reviewer)
  • @jnieuviarts (reviewer) :heavy_check_mark:
  • @dallegoet (reviewer) :heavy_check_mark:

Source: https://github.com/mapado/datection/commit/cfb5a2049267 on branch rs-fix-exrule-no-boundaries Destination: https://github.com/mapado/datection/commit/84134fc36309 on branch master Merge commit: https://github.com/mapado/datection/commit/653694c1a91e

State: MERGED

Quand le DTSTART ou le UNTIL manque à l'exception rrule, l'itération "for date in rrule" ne s'arrête pas.

C'est qu'une partie du fix, il faut trouver comment éviter d'avoir des exceptions rrules comme ça.

jdeniau commented 7 years ago

@jnieuviarts approved :heavy_check_mark: the pull request on 2017-01-09 12:35

jdeniau commented 7 years ago

@dallegoet approved :heavy_check_mark: the pull request on 2017-01-09 16:25