Closed jdeniau closed 4 years ago
Pull request :twisted_rightwards_arrows: created by @RomainMapado on 2017-05-09 13:57 Last updated on 2017-05-11 12:48 Original Bitbucket pull request id: 54 Participants: @zwit (reviewer) :heavy_check_mark: @jnieuviarts (reviewer) @jdeniau (reviewer) :heavy_check_mark: @dallegoet (reviewer) Source: https://github.com/mapado/datection/commit/179719ebd3e5 on branch rs-feat-alterations Destination: https://github.com/mapado/datection/commit/cba7eeab11fe on branch master Merge commit: https://github.com/mapado/datection/commit/6364f0e1caba State: MERGED
Pull request :twisted_rightwards_arrows: created by @RomainMapado on 2017-05-09 13:57 Last updated on 2017-05-11 12:48 Original Bitbucket pull request id: 54
Participants:
Source: https://github.com/mapado/datection/commit/179719ebd3e5 on branch rs-feat-alterations Destination: https://github.com/mapado/datection/commit/cba7eeab11fe on branch master Merge commit: https://github.com/mapado/datection/commit/6364f0e1caba
rs-feat-alterations
master
State: MERGED
MERGED
Clarification du parsing des alterations (par exemple "Du 6 au 12 décembre 2014 à 23h, sauf le mardi à 22h").
Suppression de la logique un peu foireuse qui mixait alteration et exception.
Maintenant: 1 alteration = 1 exception + 1 additional rule
@zwit commented on 2017-05-09 14:40
cool !
@zwit approved :heavy_check_mark: the pull request on 2017-05-09 14:40
@jdeniau approved :heavy_check_mark: the pull request on 2017-05-10 07:39
Clarification du parsing des alterations (par exemple "Du 6 au 12 décembre 2014 à 23h, sauf le mardi à 22h").
Suppression de la logique un peu foireuse qui mixait alteration et exception.
Maintenant: 1 alteration = 1 exception + 1 additional rule