fix set does not support indexing error

jdeniau commented 6 years ago

Pull request :twisted_rightwards_arrows: created by @jnieuviarts on 2018-02-27 13:58 Last updated on 2018-02-27 17:19 Original Bitbucket pull request id: 79

Participants:

@RomainMapado (reviewer) :heavy_check_mark:

Source: https://github.com/mapado/datection/commit/58fb4dcb10a2 on branch jn_fix_set_no_indexing Destination: https://github.com/mapado/datection/commit/e4d5e90eafd8 on branch master Merge commit: https://github.com/mapado/datection/commit/18df8e3ea953

State: MERGED

Essai de fix de cette erreur : https://sentry.mapado.net:444/mapado/python/issues/105595/ C'est étonnant car les rrule._byhour sont normalement des tuple mais avec le list() on ne devrait plus avoir le souci.

jdeniau commented 6 years ago

@RomainMapado commented on 2018-02-27 15:09

Je crois que c'est un truc tout pourri de la lib de rrule dans le init du genre

def __init__(self, byhour=None, byminute=None,...):
    self._byhour = byhour if byhour else set()

‌

jdeniau commented 6 years ago

@RomainMapado approved :heavy_check_mark: the pull request on 2018-02-27 15:09

mapado / datection

fix set does not support indexing error #79