search

maparent / virtuoso-python

RDFLib and SQLAlchemy bindings for Virtuoso
BSD 3-Clause "New" or "Revised" License
16 stars 10 forks source link

python 2 not supported anymore? #11

Closed pchampin closed 7 years ago

pchampin commented 7 years ago

I just updated from github, and my Python2 code does not work anymore.

  File ".../virtuoso/vstore.py", line 4, in <module>
    from builtins import (next, chr, zip, range, object)

Is it a bug or a feature, i.e. Is the lib now only supposed to work with Python3?

maparent commented 7 years ago

Clearly a bug, I'll have a look shortly.

maparent commented 7 years ago

did you reinstall the content of requirements.txt? It looks like you may be missing future. I have a few tests failing, but most things do work for me now.

pchampin commented 7 years ago

did you reinstall the content of requirements.txt?

I did a pip install --upgrade, which I expect to install all required dependencies...

I had a look at setup.py, and that confuses me a bit:

I started updating setup.py accordingly, but then I realized that install_requires does not support github URLS :-( It might be possible by keeping the dependency_links keyword, and forcing pip to use it, using the option --process-dependency-links, although I didn't manage to make that work yet. And even if we do manage eventually, that should at the very least be documented in the README...

maparent commented 7 years ago

I added a note in the README about using pip, and made sure that setup.py was better aligned to requirements.txt. Do you think that solves the problem?

pchampin commented 7 years ago

Works for me

On 9 September 2017 at 17:56, Marc-Antoine Parent notifications@github.com wrote:

I added a note in the README about using pip, and made sure that setup.py was better aligned to requirements.txt. Do you think that solves the problem?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maparent/virtuoso-python/issues/11#issuecomment-328285914, or mute the thread https://github.com/notifications/unsubscribe-auth/AASl5CDJLrrIaMY2m9_GkCbtJdm3dV_Xks5sgrU5gaJpZM4PRX8q .