search

mapbox-jp / holidays-rs

Rust library to provide accurate and up-to-date holiday dates based on Python holidays package
MIT License
4 stars 3 forks source link

Support subdivisions #9

Open fkrauthan opened 1 year ago

fkrauthan commented 1 year ago

It seems like python-holidays supports country subdivisions (as every countries subdivision/province often have their own holidays). I couldn't find that API exposed here? Can this be added?

yukinarit commented 4 months ago

Hi @fkrauthan Sorry for the delay :pray: if you're still interested, I can take a look.

fkrauthan commented 3 months ago

Don't really have a use-cases at the moment for this anymore (I switched to an API approach) but overall probably would still be a good addition to this library.

AD4MANTIS commented 3 months ago

I implemented subdivisions here: https://github.com/AD4MANTIS/holidays-rs/pull/1 After #11 is done I will create a PR to this repo.