mapbox / DEPRECATED-mapbox-ios-sdk

REPLACED – use https://www.mapbox.com/ios-sdk instead
https://github.com/mapbox/mapbox-gl-native
Other
323 stars 8 forks source link

add examples gallery #199

Closed incanus closed 11 years ago

incanus commented 11 years ago

It would be nice to have an examples gallery like the one for MapBox.js.

I've been working on this in the gh-pages branch locally and could use a review in the next day or two. @tristen, you have some spare cycles?

I plan on including either a static image or an embedded video in place of the HTML map for the iOS examples, and I want to make sure it works right but I'm largely cannabalizing the MapBox.js template for it.

incanus commented 11 years ago

Actually working on this over in gh-pages-draft instead.

@yhahn @samanpwbb @tristen Could I get one of you to take a peek and tidy up a bit? I've puzzled through most of the Jekyll/Liquid stuff using MapBox.js as a template to get this far. I've got a couple examples, screenshots, and navigation.

Still to do:

yhahn commented 11 years ago

@incanus y, i will try to take a look at this this weekend.

incanus commented 11 years ago

Thanks, @yhahn. Ideal timeline is with the milestone blog post scheduled for Monday.

incanus commented 11 years ago

Couple other things:

incanus commented 11 years ago

More:

incanus commented 11 years ago

Ok, I've got syntax highlighting working via Pygments built into Jekyll. We appear to already have some defaults for that, but that just might be Jekyll's default. I need to override and/or make the colors better for Objective-C.

yhahn commented 11 years ago

@incanus is there supposed to be code with the screenshots in the examples gallery? Or if the code is over on github, how do I get to it?

incanus commented 11 years ago

Yes, it's under each screenshot, so it's inline in the gh-pages-draft branch.

Justin R. Miller justin@mapbox.com @incanus77

On Mar 2, 2013, at 7:36 AM, Young Hahn notifications@github.com wrote:

@incanus is there supposed to be code with the screenshots in the examples gallery? Or if the code is over on github, how do I get to it?

— Reply to this email directly or view it on GitHub.

yhahn commented 11 years ago

o it looks like i am missing obj-c highlighting in my pygments install. will investigate.

yhahn commented 11 years ago

I pushed some adjustments.

It's worth noting that my pygments install does not have the objective-c highlighting so those whole blocks of text failed to render (I switched to just c to preview locally). If you haven't tested objective-c highlighting in a dummy gh-pages repo or so that may be a good idea just to confirm that the pygments version GH is running supports it.

incanus commented 11 years ago

Good call, will check it out. Could always ship without, then lobby GitHub for it.

Justin R. Miller justin@mapbox.com @incanus77

On Mar 2, 2013, at 8:08 AM, Young Hahn notifications@github.com wrote:

I pushed some adjustments.

It's worth noting that my pygments install does not have the objective-c highlighting so those whole blocks of text failed to render (I switched to just c to preview locally). If you haven't tested objective-c highlighting in a dummy gh-pages repo or so that may be a good idea just to confirm that the pygments version GH is running supports it.

— Reply to this email directly or view it on GitHub.

incanus commented 11 years ago

GitHub Pygments includes Objective-C.

incanus commented 11 years ago

Any thoughts @yhahn navigation-wise on getting the example apps back in here?

yhahn commented 11 years ago

Hrm, not sure if there are any good quick solutions. Something we can look into refactoring for post-launch?

incanus commented 11 years ago

Sure, I think we can do that within a week or two. I was thinking either another tab on the top (blech) or somehow integrating it into the example tabs down the left.

On Mar 4, 2013, at 3:08 PM, Young Hahn notifications@github.com wrote:

Hrm, not sure if there are any good quick solutions. Something we can look into refactoring for post-launch?

— Reply to this email directly or view it on GitHub.

Justin R. Miller justin@mapbox.com @incanus77

incanus commented 11 years ago

FWIW they are all mentioned in the SDK README so we haven't entirely dead-ended them.

On Mar 4, 2013, at 3:08 PM, Young Hahn notifications@github.com wrote:

Hrm, not sure if there are any good quick solutions. Something we can look into refactoring for post-launch?

— Reply to this email directly or view it on GitHub.

Justin R. Miller justin@mapbox.com @incanus77

yhahn commented 11 years ago

ok, yeah in general I think integrating them with the rest of the examples would be great. Maybe we have a way to layout the page to fill that space without a code snippet if it's a full repo type of example.