Fileprivate identifier on Placemark.

mapbox / MapboxGeocoder.swift

Address search and reverse geocoding in Swift or Objective-C on iOS, macOS, tvOS, and watchOS

https://www.mapbox.com/geocoding/

ISC License

131 stars 48 forks source link

Fileprivate identifier on Placemark. #168

Open Kdan opened 5 years ago

Kdan commented 5 years ago

The identifier field of the Placemark (MBPlacemark) class is currently fileprivate. This introduces complexity when persisting and matching Placemark objects. Will this be accessible in the future?

Thanks /Kewin

1ec5 commented 5 years ago

We changed the access level from private to fileprivate in #72. I think the reason for making them private was that the numeric portion of each identifier isn’t guaranteed to be stable; it’s somewhat of an implementation detail. If we expose the identifier property publicly, there might have to be a caveat about the values being arbitrary and potentially unsuitable for long-term storage.