search

mapbox / MapboxStatic.swift

Static map snapshots with overlays in Swift or Objective-C on iOS, macOS, tvOS, and watchOS
https://www.mapbox.com/api-documentation/?language=Swift#static
Other
189 stars 31 forks source link

Podfile.lock; project upgrades #38

Closed 1ec5 closed 7 years ago

1ec5 commented 7 years ago

This PR checks in Podfile.lock (and stops ignoring it) and upgrades OHHTTPStubs/Swift to a release (instead of a commit). It also upgrades project build settings and schemes according to Xcode 8 recommendations, except for disabling code signing on watchOS targets. Finally, it sets BITCODE_GENERATION_MODE so that applications that link against this library can archive.

/cc @friedbunny

incanus commented 7 years ago

Hmm, I just undid this in https://github.com/mapbox/MapboxStatic.swift/commit/e31f18c1dba7c8c8a7b03b168a3b0f0dc036acd5 as typical procedure isn't to version Podfile.lock. Can you say more about why given that the versions are tracked in Podfile?

1ec5 commented 7 years ago

Podfile.lock should always be checked in:

Whether or not you check in the Pods directory, the Podfile and Podfile.lock should always be kept under version control.

In fact, Bitrise’s CocoaPods step depends on the checked-in Podfile.lock to choose a version of CocoaPods to use:

  Searching for Podfile.lock
No Podfile.lock found at: /Users/vagrant/git/Podfile.lock
Make sure it's committed into your repository!
  Using system installed CocoaPods version
incanus commented 7 years ago

Reverted in https://github.com/mapbox/MapboxStatic.swift/commit/9e2c5a96687c6c8b44e845863440b67aee497f22 for now.