mapbox / MapboxStatic.swift

Static map snapshots with overlays in Swift or Objective-C on iOS, macOS, tvOS, and watchOS
https://www.mapbox.com/api-documentation/?language=Swift#static
Other
189 stars 31 forks source link

Don’t even try to deserialize non-JSON response data #40

Closed 1ec5 closed 7 years ago

1ec5 commented 7 years ago

For consistency with mapbox/MapboxDirections.swift#72 and mapbox/MapboxGeocoder.swift#71, don’t attempt to deserialize non-JSON response data. In the case of this library, the error would’ve been caught by the expected fallback of initializing an image out of the data. But it’s quite bizarre for the “good” code path to be inside an error handler. So now this library is additionally capable of tripping an assertion if the response claims to be JSON but isn’t well-formed for some reason.

/cc @willwhite