search

mapbox / MapboxStatic.swift

Static map snapshots with overlays in Swift or Objective-C on iOS, macOS, tvOS, and watchOS
https://www.mapbox.com/api-documentation/?language=Swift#static
Other
189 stars 31 forks source link

Specify Swift version in podspec #73

Closed friedbunny closed 5 years ago

friedbunny commented 6 years ago

CocoaPods 1.4.0 supports a swift_version setting in podspecs, so this adds that.

CocoaPods also says that the .swift-version file is being deprecated, but they’re not the only consumers of this file, so let's leave it around for the time being.

/cc @1ec5

friedbunny commented 6 years ago

Updated this for Swift 4 (#75).

bsudekum commented 6 years ago

Do we have to do the if check still? https://github.com/mapbox/mapbox-navigation-ios/blob/b57c8e78355211d59e06ce67714298012b129994/MapboxCoreNavigation.podspec#L49-L51

1ec5 commented 6 years ago

CocoaPods 1.4.0 was released in February. Would leaving the check in for now have any downside?

friedbunny commented 6 years ago

While there’s no harm (that I’m aware of) in adding a pre-1.4.0 check, I don’t think it’s necessary: it’s only an issue when 1. the user is using <1.4.0 (now at least two versions ago), and 2. directly specifies this podspec by URL.

We shouldn’t encourage users to directly specify podspec URLs, as doing so is not secure and allows arbitrary code execution (if someone were to somehow insert malicious ruby into our podspec). More details in https://github.com/mapbox/mapbox-navigation-ios/pull/1134#issuecomment-367146759.

friedbunny commented 5 years ago

Bump — I think this is still relevant. /cc @frederoni @1ec5

friedbunny commented 5 years ago

We got this in #83.