search

mapbox / MapboxStatic.swift

Static map snapshots with overlays in Swift or Objective-C on iOS, macOS, tvOS, and watchOS
https://www.mapbox.com/api-documentation/?language=Swift#static
Other
188 stars 31 forks source link

Fix compiler warning #80

Closed frederoni closed 5 years ago

frederoni commented 5 years ago

let properties are implicitly final so use public access modifier instead of open.

/cc @1ec5

bsudekum commented 5 years ago

Should we move the other opens to public as well?

frederoni commented 5 years ago

This was the only property Xcode 10 complained about so I guess the others are correct. (var open or let/static public)

bsudekum commented 5 years ago

Strange, I wonder why.

frederoni commented 5 years ago

@bsudekum Basically what the warning specifies "static declarations and let properties are implicitly marked final". Final is not overridable so it contradicts open, therefore static/let should be public/private/fileprivate. open is still the appropriate access modifier to use for overridable properties and methods.