mapbox / MapboxStatic.swift

Static map snapshots with overlays in Swift or Objective-C on iOS, macOS, tvOS, and watchOS
https://www.mapbox.com/api-documentation/?language=Swift#static
Other
188 stars 31 forks source link

Rename map identifiers to tileset identifiers #92

Closed 1ec5 closed 4 years ago

1ec5 commented 5 years ago

Map IDs are being renamed to tileset IDs across the board. The only impacts to this library are the ClassicSnapshotOptions.mapIdentifiers property and associated initializer arguments:

https://github.com/mapbox/MapboxStatic.swift/blob/413173cf1dd47114de34cb89a4bb041c72e034e5/MapboxStatic/ClassicSnapshotOptions.swift#L71 https://github.com/mapbox/MapboxStatic.swift/blob/413173cf1dd47114de34cb89a4bb041c72e034e5/MapboxStatic/ClassicSnapshotOptions.swift#L149

/cc @mapbox/maps-ios @brsbl

zugaldia commented 5 years ago

/cc: @osana for Android (MAS).

1ec5 commented 5 years ago

mapbox/mapbox-java#1021 tracks the changes needed in the Java SDK. As far as I can tell, the Java SDK only supports the modern Static API, not the classic one that uses map tileset IDs, so only the Tilequery API code is affected.