search

mapbox / Simple-KML

Simple KML is a simple & lightweight parsing library for KML written in Objective-C for the iOS platform.
BSD 3-Clause "New" or "Revised" License
208 stars 58 forks source link

non ARC compliant zip classes #12

Open krisbulman opened 12 years ago

krisbulman commented 12 years ago

The dev-arc branch compiles fine with the -fno-obj-arc compile flag set on the following files

FileInZipInfo.m ZipFile.m ZipReadStream.m ZipWriteStream.m

However, I was wondering what the background is here, does a standard arc migration on these files (removal of release, dealloc, etc) continue to cause problems after the fact?

incanus commented 12 years ago

Hadn't tried them yet -- just took a stab at ARC for the main library, which is why it's in a branch.

incanus commented 12 years ago

Just to follow up on this, I probably will leave it as non-ARC since it'a a dependency and outside code. I will be checking dependencies shortly, though, to update them if necessary.

ronak2121 commented 11 years ago

There is an ARC-ed branch available in the Objective-Zip Submodule. Why not just switch to that branch? I'm trying to add -fno-obj-arc to the above files but I still get compilation errors complaining about ARC.

incanus commented 11 years ago

Cool, I don't believe this was around before. Will investigate.

incanus commented 11 years ago

@ronak2121 where you are seeing this ARC branch? I see an attempt at ARC that was later reverted in https://github.com/AgileBits/objective-zip

ronak2121 commented 11 years ago

I see it here:

https://github.com/CoolEmber/Objective-Zip

From: Justin R. Miller notifications@github.com To: mapbox/Simple-KML Simple-KML@noreply.github.com Cc: ronak2121 ronak2121@yahoo.com Sent: Wednesday, January 23, 2013 6:19 PM Subject: Re: [Simple-KML] non ARC compliant zip classes (#12)

@ronak2121 where you are seeing this ARC branch? I see an attempt at ARC that was later reverted in https://github.com/AgileBits/objective-zip — Reply to this email directly or view it on GitHub.