search

mapbox / abaculus

Library for creating static maps from tiles based on center or corner lng,lat coordinates. Uses node-blend.
ISC License
127 stars 38 forks source link

Fixed bugs for low zooms with tiles exceeding the world's size #21

Closed nyurik closed 7 years ago

nyurik commented 8 years ago

For smaller zooms, or when asking for images at the edge of the world, fixed bugs with tile list generation

nyurik commented 8 years ago

CC: @flippmoke

flippmoke commented 8 years ago

/cc @camilleanne @yhahn

nyurik commented 8 years ago

@flippmoke @camilleanne @yhahn Hi, any updates on this PR?

camilleanne commented 8 years ago

hi @nyurik -- I'll review this today. Could you restart the travis build that failed? https://travis-ci.org/mapbox/abaculus/jobs/121131105

nyurik commented 8 years ago

@camilleanne the mapnik-config keeps failing for node 12, but seems to be fine for node 10. Hae you seen this before? Is that a bug in the PR or somewhere else?

nyurik commented 8 years ago

@camilleanne If you have any questions, ping me on IRC - yurik (i'm in the # mapbox and various wikimedia-* channels)

nyurik commented 8 years ago

@flippmoke @camilleanne @yhahn I re-based my changes on top of your rewrite with the tile sizes. Lets merge this soonish so that it doesn't diverge too far again. There is a number of critical bug fixes that we really need in our env. Thanks!