search

mapbox / assembly

Making the hard parts of designing for the web easy.
https://www.mapbox.com/assembly/
134 stars 27 forks source link

Deprecate limiter #949

Closed tristen closed 3 years ago

tristen commented 4 years ago

Closes #942

Here's the stats after changes:

CSS: 176 kB (minified) => 22.2 kB (gzipped)
SVG: 50.7 kB => 15.9 kB (gzipped)

vs what's currently 1.0.0

CSS: 172 kB (minified) => 21.6 kB (gzipped)
SVG: 50.7 kB => 15.9 kB (gzipped)
tristen commented 3 years ago

Could we add instead add % width classes that have media query modifiers and deprecate limiter? This would be simpler and more in line with Assembly's philosophy.

I like this idea! I wonder if we can rely on the existing col-- classes instead. col--10 mx-auto px0 is a near fit for limiter apart from a pixel-defined max-width. I wonder if we should add some larger wmax values instead?

samanpwbb commented 3 years ago

I wonder if we should add some larger wmax values instead?

Yes, lets do this

tristen commented 3 years ago

This needs another pass but is otherwise ready for review.

samanpwbb commented 3 years ago

Broke out the grid refactor as a separate issue: https://github.com/mapbox/assembly/issues/994