search

mapbox / carto

fast CSS-like map stylesheets
https://cartocss.readthedocs.io/
Apache License 2.0
652 stars 129 forks source link

OSM Bright theme rendering black roads #471

Closed StarFi55ure closed 7 years ago

StarFi55ure commented 7 years ago

I have a problem with the mapbox osm-bright theme when rendered with a carto generated mapnik xml file. In the bridges layer, the bridges are rendered black instead of their normal colors.

Ive attached a picture below, in which I deactivated the roads layers to show just the bridges. When I generate a mapnik xml directly from TileOven, the rendering is fine.

Carto: v0.17.2 NodeJS: 4.8.2 Mapnik version: 3.0.13 Command used: carto project.mml > project.xml

Carto XML Rendering

image

TileOven XML Rendering

image

nebulon42 commented 7 years ago

Thanks for the report, I'll investigate. Affects 0.17.2 and master. Does not affect 0.16.3.

nebulon42 commented 7 years ago

Git bisect tells me that 9be4e86806b0baa50b76cf70e9096a5a24877453 introduced this behaviour.

Problem is that I didn't expect parseFloat being that dump having that feature. OSM Bright uses filters of the form [render='1_outline'] which parseFloat treats as number because they begin with one.

nebulon42 commented 7 years ago

Fixed in v0.17.3.