Upgrade Mocha to latest version

hiddewie commented 3 years ago

Solves a security advisory

───────────────┬──────────────────────────────────────────────────────────────┐
 low           │ Prototype Pollution                                          │
───────────────┼──────────────────────────────────────────────────────────────┤
 Package       │ minimist                                                     │
───────────────┼──────────────────────────────────────────────────────────────┤
 Patched in    │ >=0.2.1 <1.0.0 || >=1.2.3                                    │
───────────────┼──────────────────────────────────────────────────────────────┤
 Dependency of │ mocha                                                        │
───────────────┼──────────────────────────────────────────────────────────────┤
 Path          │ mocha > mkdirp > minimist                                    │
───────────────┼──────────────────────────────────────────────────────────────┤
 More info     │ https://www.npmjs.com/advisories/1179                        │
───────────────┴──────────────────────────────────────────────────────────────┘

gravitystorm commented 3 years ago

@hiddewie Do you have any insights into the test failure here?

hiddewie commented 3 years ago

@gravitystorm

In the changelog of mocha: https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#720--2020-05-22

They dropped support for pre-node-12 versions.

I downgraded this update to mocha 7.x.x which should support node 8.

coveralls commented 3 years ago

Coverage remained the same at 89.532% when pulling 63b6ea7656757edc40d3b51f62bffab8eb3758c7 on hiddewie:upgrade-mocka into 8d79a4f3f242a8ae8f36f9fc425938c102d7591f on mapbox:master.

gravitystorm commented 3 years ago

I downgraded this update to mocha 7.x.x which should support node 8.

Great, thank you for investigating.

mapbox / carto

Upgrade Mocha to latest version #508