search

mapbox / cloudfriend

Helper functions for assembling CloudFormation templates in JavaScript
ISC License
69 stars 9 forks source link

Fix typo in Glue database shortcut #109

Closed drboyer closed 4 years ago

drboyer commented 4 years ago

Just recently used the GlueDatabase shortcut and realized there's a small interpolation error in the Description field. This PR corrects it.

It also adds a new script to update the test fixtures, since it didn't previously exist. Running it yielded changes to the hookshot fixtures, they look pretty innocuous though.

rclark commented 4 years ago

Part of the reason that I haven't included that kind of "easy update all the fixtures" tool is to avoid those hookshot diffs. Do you mind removing those changes? I'd prefer to keep cleaner commits and simpler review process.

drboyer commented 4 years ago

ahh gotcha, I understand. I've reverted and just manually updated the affected snapshot.