mapbox / cloudfriend

Helper functions for assembling CloudFormation templates in JavaScript
ISC License
69 stars 9 forks source link

Lambda/Role changes #113

Closed drboyer closed 3 years ago

drboyer commented 3 years ago

What's this PR?

What's left?

I left a question in #103 about some advanced functionality @rclark originally suggested. We should probably come to a conclusion on that before merging this.

About this review

drboyer commented 3 years ago

I've updated this PR to attach a new LogPolicy to all Lambdas, per discussion. Based on that I had to re-jigger some configuration in the Stream and Queue lambdas, but hopefully the change makes sense.

I'll give this a try in a PR where I'd like to provide my own role, but in the meantime, putting this back up for review.