Before this commit, every time we ran Travis CI builds, we'd pass a bunch of shortcut-outputs through a cloudformation:ValidateTemplate API call. This PR replaces those calls with running cfn-lint.
This means we don't have to provide any AWS Access to Travis CI 👍
Turns out cfn-lintis better at validating templates than the AWS API is. This uncovered a syntax error in hookshot's handling of access logs, specification of status codes, and also several places where our tests were feeding invalid values into the shortcuts.
So we're doing better validation now, without needing the AWS Access.
Before this commit, every time we ran Travis CI builds, we'd pass a bunch of shortcut-outputs through a
cloudformation:ValidateTemplateAPI call. This PR replaces those calls with running cfn-lint.cfn-lintis better at validating templates than the AWS API is. This uncovered a syntax error in hookshot's handling of access logs, specification of status codes, and also several places where our tests were feeding invalid values into the shortcuts.So we're doing better validation now, without needing the AWS Access.