Closed danmactough closed 5 years ago
Thanks @rclark. I didn't want to over-engineer it before getting feedback; I appreciate your points.
I think the way we should model the firehose shortcuts is:
So, I'd like to limit this PR to the base class + S3 destination.
Unlike the Lambda shortcut, the base firehose wouldn't be usable without the additional functionality of one of the subclasses (or your own custom subclass).
Unlike the Lambda shortcut, the base firehose wouldn't be usable without the additional functionality
That's fine -- just don't have the cloudfriend module export the "abstract" class?
just don't have the cloudfriend module export the "abstract" class?
That's what I'm thinking, but the downside would be that you wouldn't be able to implement a custom subclass. I think that better fits the spirit of this project, though.
@rclark Implemented something via 807b43c. Thoughts?
Last thing: could you add a sentence or two here describing the alarm that is created?
Done via 9d2eebd
Adds a new shortcut for creating a Kinesis Firehose that writes out to the specified S3 bucket. It can be a "direct put" firehose (with
firehose.putRecord()
orfirehose.putRecordBatch()
), or you can specify an input Kinesis Stream ARN.