mapbox / cloudfriend

Helper functions for assembling CloudFormation templates in JavaScript
ISC License
69 stars 9 forks source link

"Columns" property not being passed to StorageDescriptor in GlueTable shortcut #91

Closed nickcordella closed 4 years ago

nickcordella commented 4 years ago

I don't think the Columns property is being passed to the Storage Descriptor in the Glue Table shortcut. I noticed this because I created a Glue Table using the shortcut and confirmed that the correct physical storage files on S3 were identified, but to my surprise the only column in the resulting table was my partition column, rather than those I had specified in shortcuts.GlueTables.options. I believe the fix is basically adding Columns to this list. If this is in fact a bug, I am hopefully capable of PR'ing a fix myself.