rename glue view and add sparksql view

mapbox / cloudfriend

Helper functions for assembling CloudFormation templates in JavaScript

ISC License

69 stars 9 forks source link

rename glue view and add sparksql view #95

Closed Ramshackle-Jamathon closed 4 years ago

Ramshackle-Jamathon commented 4 years ago

This pr:

renames GlueView to GlueAthenaView, which more accurately reflects what it does
adds a GlueSparkSQLView to support defining views that can be used by spark applications running in EMR or any other spark environment using glue as the metastore.

cc @mapbox/data-tools

rclark commented 4 years ago

I would strongly encourage (a) each of these individually and (b) a "wrapper" shortcut that builds one of each. Naming maybe is the only confusing part.

Ramshackle-Jamathon commented 4 years ago

(b) a "wrapper" shortcut that builds one of each

Keeping in mind that the syntax of sparkSQL and prestoSQL are not cross compatible, what params do you think the combined wrapper would have? Or should it just be implied that you use syntax shared by both when using it?

rclark commented 4 years ago

Oh I see what you mean. Ok, let's keep them separated.

Would GlueSparkView and GluePrestoView be acceptable names?

Ramshackle-Jamathon commented 4 years ago

Would GlueSparkView and GluePrestoView be acceptable names?

👍 yeah that works for me

rclark commented 4 years ago

Uh oh. No tests!