Native types for LastEvaluatedKey and ExclusiveStartKey.

mapbox / dyno

simple dynamodb client

MIT License

78 stars 28 forks source link

Native types for LastEvaluatedKey and ExclusiveStartKey. #104

Closed willwhite closed 9 years ago

willwhite commented 9 years ago

Dyno now uses native format (not wire format) for metas[*].last (aka LastEvaluatedKey).
Callers must use native format (not wire format) when passing in opts.start (aka ExclusiveStartKey).
Improve robustness of tests slightly because the two changes above didn't cause any tests to fail :grin:
Remove dead code that was copying opts.start to params.ExclusiveStartKey. We are doing this in dynamoRequest.

willwhite commented 9 years ago

@rclark I'm satisfied with the tests now. Can you :eyes: ?

This is not a critical change and I'm inclined to just merge and wait for another substantial change before bothering with a release.

rclark commented 9 years ago

LGTM -- I would go for a release if for no other reason than being able to use it in https://github.com/mapbox/cardboard/pull/152. Shouldn't have to mess with wire-format in a lib that otherwise relies on dyno for object simplification.