search

mapbox / earcut.hpp

Fast, header-only polygon triangulation
ISC License
858 stars 133 forks source link

Viz app broken on recent OS X #78

Open springmeyer opened 5 years ago

springmeyer commented 5 years ago

The build currently fails with >= 10.14 due to the combo of deprecation warnings + -Werror:

/Users/travis/build/mapbox/earcut.hpp/test/viz.cpp:67:9: error: 'glViewport' is deprecated: first deprecated in macOS 10.14 - OpenGL API deprecated. (Define GL_SILENCE_DEPRECATION to silence these warnings) [-Werror,-Wdeprecated-declarations]
        glViewport(0, 0, viewWidth, viewHeight);
        ^

https://travis-ci.org/mapbox/earcut.hpp/jobs/586690931#L629

This can be trigged by changing travis to test with xcode_image: 11 instead of osx_image: xcode8

mrgreywater commented 5 years ago

OSX is dropping support for OpenGL. Nothing we can really do about it, except for adding Metal support (doubt anybody feels inclined to do so).

For now I suggest we define GL_SILENCE_DEPRECATION for OSX and leave it at that.