search

mapbox / earcut.hpp

Fast, header-only polygon triangulation
ISC License
858 stars 133 forks source link

Do not run bench on CI #79

Closed mourner closed 3 years ago

mourner commented 5 years ago

This doesn't seem to serve much purpose (we usually only check bench results when running it locally during optimization passes), so I'd rather have faster CI builds.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 98.008% when pulling 32e835971e0bd51a655b0c2c6b9d7958dd77b97f on ci-no-bench into c00b7cd52285bc65a283ec5524a707c2f8bcdce3 on master.

mrgreywater commented 5 years ago

Maybe we could leave the bench on one of the builds, just so we can see if there are any major performance regressions.

mrgreywater commented 3 years ago

@mourner Do you still want to remove the benchmarking from the CI? From a historical point of view, it's nice to be able to have a history of past results, even though their use is limited due to them running on random VM's. It doesn't matter greatly, if you want to remove them, it's fine.

mourner commented 3 years ago

I guess it's not a big deal, with jobs running in ~4 min. Let's close and reevaluate if there's a need.