mapbox / gabbar

Guarding OpenStreetMap from harmful edits using machine learning
MIT License
19 stars 7 forks source link

Scripts and documentation to prep data and train model #3

Closed bkowshik closed 7 years ago

bkowshik commented 7 years ago

Per https://github.com/mapbox/osmcha/pull/5#issuecomment-276727180

Objective

defvol commented 7 years ago

Also, can we rename 'Instructions to prep data and train model' to 'Add scripts and docs for data prep and training'? to make it clear that the commit not only adds docs but also the scripts

bkowshik commented 7 years ago

Also, can we rename 'Instructions to prep data and train model' to 'Add scripts and docs for data prep and training'?

This was wonderful to learn about. git is amazing!

Documentation

bkowshik commented 7 years ago

LGTM, I fixed the train/test partition in 79d18ff. If that works for you we can merge.

@rodowi, I did the commit message rename first and that resulted in your commit go missing. I have added that back with https://github.com/mapbox/gabbar/pull/3/commits/ce904ace79e471a456979246ac92821dac19453d 😃

screen shot 2017-02-07 at 3 59 10 pm
defvol commented 7 years ago

and that resulted in your commit go missing

no worries good that the code was merged