Closed dasulit closed 7 years ago
@dasulit Looking good! A couple of things:
Did you decide against making the category values arrays? I do think this is important because a lot of the features fall under multiple categories.
The following deleted/combined tags are specific Mapbox Streets data layer names or values (or terms that represent numeric values), or otherwise useful, so I think we should keep them:
Also, barrier
does make more sense than barrier_line
, but just noting that barrier_line
is the actual name of the data layer.
@dasulit @nickidlugash how would it sound to:
Sounds good to me! I just amended my commit to reintroduce those tags. The places I removed them from were already categorized by other tags (with the exception of national capitals, which I tossed in with cities, and landuse_overlay, which folded in with landuse). Script updated too.
Noting that the successes and shortcomings of these tag categorizations are already starting to surface as I'm using the data in an interface. I think making some observations and decisions from some brief user (cartographer) testing with carto-cam would be helpful, and from there I can work out a gazetteer 2.1 PR.
^ cc @samanpwbb @nickidlugash
Proposing some changes for Gazetteer 2.0!
The main change is the addition of a
category
property derived from the existing tags. These higher-level categories help organize the geoJSON by grouping places together, and hopefully provide a clearer point of entry to gazetteer for cartographers.Please see the script I used to process the data here: https://gist.github.com/dasulit/4c45db9dd583ed191c15aff39abb7f8e
Other changes to note:
category
.@samanpwbb and @nickidlugash for review!