Closed dasulit closed 6 years ago
Looks like @nickidlugash removed the empty data_layer_field objects where data_layer: building and there are no meaningful data_layer_fields— and @lukasmartinelli added them back to make tests pass 😀 were you intending that the tests should be updated to make data_layer_fields optional, Nicki?
were you intending that the tests should be updated to make data_layer_fields optional, Nicki?
@dasulit I have no preference, I was just looking back at this comment yesterday and thought that your preference was for this field not to exist if it's empty.
Repurposing this PR for the revamped Gazetteer 3.0!
@dasulit @aparlato pls review/comment/edit the spec proposal. I don't know the conventions for writing a spec (e.g. how to indicate optional fields) – please update the formatting if you see anything that could be written more clearly.
Can/should we allow numbers and booleans for tag and data field values?
Thanks for reviving @nickidlugash!
Can/should we allow numbers and booleans for tag and data field values?
Yep, I think we can and should 👍
Can/should we allow numbers and booleans for tag and data field values?
Agreed.
@nickidlugash spec proposal looks good to me!
@dasulit @aparlato thanks for the review! Updated based on your comments.
@aparlato I updated the top-level comment with a new summary of gazetteer-3. Please review! 🙏
@dasulit To update tests, looks like we need to update:
mapbox-streets
directorytag
, remove highlights
from the "required" test, since we've now made it optional).I'm happy to make these updates, but i'm not sure what the best way is to do 1.
@nickidlugash @aparlato I just pushed a commit that fixes the failing tests. Would love for you two to take a quick look at these changes before 🚢
@aparlato :ducttape: Thanks for your guidance! I incorporated your changes, save for your comment on the lint function, which I responded to inline. Let me know if this all looks good to you.
@dasulit nice! one last little thing:
We need to move "@mapbox/geojsonhint": "^2.1.0"
from devDependencies
to dependencies
so that it gets installed with the package (I learned this the hard way on highway shield icons module). devDependencies
don't get installed with a package and only exist for local development to install while working locally so that they don't bloat apps with stuff they don't need in the wild like js formatting.
Missed that in the shuffle, should be good now @aparlato.
@dasulit awesome! 🚢
UPDATE: We significantly reworked this version of gazetteer:
Previous summary
Closes https://github.com/mapbox/gazetteer/issues/17 by introducing a new structure for feature properties that closely leans on the Mapbox Streets source!
Closes https://github.com/mapbox/gazetteer/issues/18 by renaming
gazetteer.json
tomapbox-streets-gazetteer.geojson
, with the intent that curated gazetteers can be made for different tilesets. No longer relevant.Old checklist:
port over all Places from gazetteer 2.0Puntingdecide syntax for category arrayNo longer in speccreate category array for Mapbox Streets gazetteerNo longer in specdata_layer_fields
is an optional key / update Places as neededfix zoom levels on ported PlacesPuntingreview all names of ported PlacesPuntingcc @nickidlugash