mapbox / geojson-mapnikify

Transform GeoJSON objects into Mapnik XML stylesheets with embedded GeoJSON data and simplestyle-spec-derived styles.
ISC License
38 stars 22 forks source link

Don't set defaults on url markers by default #23

Closed yhahn closed 8 years ago

yhahn commented 8 years ago

Looks like this fix https://github.com/mapbox/geojson-mapnikify/pull/20 revealed another bug -- once marker-color started working for marker-url it applied to all marker-url features as they were all having default properties set.

The fix skips applying default properties to marker-url features.

cc @jakepruitt @flippmoke

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.2%) to 87.692% when pulling c942e0ecacece7d11be3d6b5f950af6ddda3ea1d on greyhound into 19522aeb8afc8a3c6c7549ca9f3698b9e4d04999 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-2.2%) to 87.692% when pulling c942e0ecacece7d11be3d6b5f950af6ddda3ea1d on greyhound into 19522aeb8afc8a3c6c7549ca9f3698b9e4d04999 on master.