search

mapbox / geojson-merge

Merge multiple GeoJSON files into one FeatureCollection.
ISC License
233 stars 33 forks source link

Make criteria for using streaming mode clearer #18

Closed scottsfarley93 closed 7 years ago

scottsfarley93 commented 7 years ago

Documentation request to make it more clear when it is required to use the streaming mode.

I am trying to combine many geojson files (>100). Without streaming mode (no -s), not all features are combined, and many (>10,000) features are simply null in the output merged file. When using -s, all files are merged properly and no features come back as null. Clearly some type of limit was reached on the normal mode that caused all future files to to be properly merged.

tmcw commented 7 years ago

Are you using 1.0.2? You may be running into a bug in 1.0.1 that was fixed. If geojson-merge runs into a limit, it should/will fail noisily.

scottsfarley93 commented 7 years ago

Yep. Updating the package fixed it. Thanks!

I still might suggest giving a bit more on the difference between streaming and normal modes.