Version 2.0 candidate - Githubissues

mapbox / geometry.hpp

C++ geometry types

ISC License

92 stars 37 forks source link

Version 2.0 candidate #60

Closed flippmoke closed 5 years ago

flippmoke commented 5 years ago

The algorithms branch has been in development for quite some time and is a series of fundamental differences between a few assumptions previously built into geometry.hpp library.

Breaking Changes

Addition of empty in variant
mapbox::geometry::feature now is mapbox::feature::feature and is in different location header.
Feature id is now a variant

Dev Changes

HPP Skel layout
Catch HPP for testing
Added google benchmark for testing perf
Added clang format and clang tidy

brunoabinader commented 5 years ago

mapbox::geometry::feature now is mapbox::feature::feature and is in different location header.

What's the rationale for this change?

flippmoke commented 5 years ago

@brunoabinader the rationale for the change is to not require the use of feature.hpp by default when including geometry.hpp. Ideally these are different concepts and you should be getting geometry.hpp when including feature.hpp not the other way around.