search

mapbox / geometry.hpp

C++ geometry types
ISC License
92 stars 37 forks source link

Compiler independent warnings #69

Open mathisloge opened 3 years ago

mathisloge commented 3 years ago

This is the same as https://github.com/mapnik/mapnik/pull/4189

It will replace gcc/clang specific pragma warnings with compiler independent ones.

mathisloge commented 3 years ago

mhm. https://travis-ci.com/github/mapbox/geometry.hpp/jobs/460974148 fails due to the format run. The line #define MAPBOX_GEOMETRY_DISABLE_WARNING_FLOAT_EQUAL MAPBOX_GEOMETRY_DISABLE_WARNING(-Wfloat-equal) should be formatted to #define MAPBOX_GEOMETRY_DISABLE_WARNING_FLOAT_EQUAL MAPBOX_GEOMETRY_DISABLE_WARNING(-Wfloat - equal)

But that results in a build error because of the spaces between Wfloat and equal. Does any one know how to ignore the formatting at this line? Is wrapping the line in// clang-format [off/on] enough for the ci?

mathisloge commented 3 years ago

\ping @flippmoke since you seem to be the active maintainer of this repo?