search

mapbox / hpp-skel

Skeleton for C++ header-only libraries
Creative Commons Zero v1.0 Universal
119 stars 19 forks source link

use catch.hpp instead of assert #23

Closed mapsam closed 7 years ago

mapsam commented 7 years ago

Let's use catch.hpp instead of assert, since assert comes with some odd Release/Debug quirks that can make it possible to incorrectly run tests successfully (if the -DNDEBUG flag is used).

Catch is on Mason now, so let's use that instead of copying.

cc @springmeyer @GretaCB

GretaCB commented 7 years ago

👍 Integrated catch into gzip branch, I'll plan to create a PR adding catch to this skel...

Catch is on Mason now, so let's use that instead of copying.

🎉 with Mason's integrated version, not separate header.

GretaCB commented 7 years ago

Ah nevermind, just seeing https://github.com/mapbox/hpp-skel/pull/20#issuecomment-324378902

GretaCB commented 7 years ago

Started PR over at https://github.com/mapbox/hpp-skel/pull/44