search

mapbox / ios-sdk-examples

Live example code for the Mapbox iOS SDK
https://www.mapbox.com/ios-sdk/examples/
Other
96 stars 35 forks source link

Navigation SDK v0.23.0 #231

Closed 1ec5 closed 6 years ago

1ec5 commented 6 years ago

Upgraded to navigation SDK v0.22.0 v0.23.0, which changes an initializer signature in a way that only affects the Objective-C setup example.

/cc @JThramer @akitchen @friedbunny

friedbunny commented 6 years ago

@akitchen @JThramer what’s the review status on this?

akitchen commented 6 years ago

The change seems simple enough, but the CI task is flaky. what to do?

friedbunny commented 6 years ago

@akitchen The flappy tests are in the main maps SDK project and are failing before the navigation target can run, so my suggestion is to rebase this PR onto master (now that #237 has landed to stop the flapping) and go from there. 🐦 🙇

1ec5 commented 6 years ago

Rebased and updated to v0.23.0.