search

mapbox / ios-sdk-examples

Live example code for the Mapbox iOS SDK
https://www.mapbox.com/ios-sdk/examples/
Other
96 stars 35 forks source link

Map SDK v4.7.1, navigation SDK v0.28.0, SwiftLint v0.30.1 #267

Closed 1ec5 closed 5 years ago

1ec5 commented 5 years ago

Upgraded to map SDK v4.7.1, navigation SDK v0.28.0, and SwiftLint v0.30.1.

/cc @JThramer @friedbunny

1ec5 commented 5 years ago

The tests are failing consistently on Bitrise:

ExamplesUITests
    ✗ testEveryExample, Application state is still unknown for com.mapbox.examples (pid:2774)
ExamplesUITests
  testEveryExample, Application state is still unknown for com.mapbox.examples (pid:2774)
  ExamplesUITests.m:161
     Executed 1 test, with 1 failure (0 unexpected) in 125.321 (125.327) seconds
xcode test exit code: 65
xcode test failed, error: exit status 65
friedbunny commented 5 years ago

Not the most informative test failure on CI, but if you run this locally you can figure out that it’s FeatureSelectionExample (both ObjC and Swift) failing — it was updated to look for a v8 layer name, but the styles that use v8 data were backed out in 4.7.1.

Proposed a fix for this in #269.

/cc @captainbarbosa