search

mapbox / ios-sdk-examples

Live example code for the Mapbox iOS SDK
https://www.mapbox.com/ios-sdk/examples/
Other
95 stars 35 forks source link

Fix swiftlint warnings #302

Closed friedbunny closed 5 years ago

friedbunny commented 5 years ago

A recent swiftlint update (0.31.0 or 0.32.0) and/or new examples added a bunch of new warnings to this project that we need to resolve. Here’s a sampling:

ios-sdk-examples/Examples/Swift/MissingIconsExample.swift:7: Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

ios-sdk-examples/Examples/Swift/MissingIconsExample.swift:45: Redundant Void Return Violation: Returning Void in a function declaration is redundant. (redundant_void_return)

ios-sdk-examples/Examples/Swift/MissingIconsExample.swift:23: Trailing Semicolon Violation: Lines should not have trailing semicolons. (trailing_semicolon)

ios-sdk-examples/Examples/Swift/MissingIconsExample.swift:13: Todo Violation: TODOs should be resolved (This is a test case, it should...). (todo)

ios-sdk-examples/Examples/Swift/TextFormattingExample.swift:37: Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)

@captainbarbosa @mapbox/maps-ios

friedbunny commented 5 years ago

Close enough to fixed in #312.