search

mapbox / ios-sdk-examples

Live example code for the Mapbox iOS SDK
https://www.mapbox.com/ios-sdk/examples/
Other
95 stars 35 forks source link

Adds / simplifies mapview ornaments layout example #377

Closed nishant-karajgikar closed 3 years ago

nishant-karajgikar commented 4 years ago

This PR builds on @lloydsheng 's work in #297 for the ornaments layout example by addressing the review comments.

Mainly, this PR simplifies the example a bit and adds associated documentation to guide the reader along as they look for examples to manipulate the ornaments in their map views.

lloydsheng commented 4 years ago

@nishant-karajgikar Thank you. Do you think the example is sufficient to demonstrate ornaments layout APIs?

nishant-karajgikar commented 4 years ago

Hi @lloydsheng ! Thanks for reviewing!

Good question, I was mainly using this PR to address the review comments in your original PR (link). To be honest, I'm slightly unsure about whether this example is necessary at all. It seems like something that should be folded into other examples and users should be educated on it via documentation.

Curious what you think though!

captainbarbosa commented 4 years ago

@nishant-karajgikar feel free to merge when ready 👍