search

mapbox / leaflet-pip

point in polygon intersections for leaflet
https://mapbox.github.io/leaflet-pip/
BSD 2-Clause "Simplified" License
199 stars 46 forks source link

Added dependencies to bower and componentjs defs. #13

Closed IvanSanchez closed 9 years ago

tmcw commented 9 years ago

Hm, I don't quite know how component/bower dependencies work... will this install leaflet alongside leaflet-pip? Error if it isn't installed? Fwiw, leaflet-pip is compatible with both mapbox.js and leaflet, and I doubt that either package manager would be able to grep the difference.

IvanSanchez commented 9 years ago

This pulls leaflet alongside leaflet-pip (as demonstrated by running bower install https://github.com/IvanSanchez/leaflet-pip.git#f9ce743e in an empty dir). This also tells build systems to minify leaflet before leaflet-pip.

And now that I look into it: yes, both package managers are quite naïve, and don't seem to handle alternative dependencies :-(

IvanSanchez commented 9 years ago

Apparently the issue of alternative dependencies was discussed in bower over two years ago: https://github.com/bower/bower/issues/173

tmcw commented 9 years ago

I'd kind of prefer to keep the bower/component packages very slim, and not expect them to be mature about dependencies: use npm+browserify, or use downloads.