search

mapbox / maki

A POI Icon Set
http://labs.mapbox.com/maki-icons/
Creative Commons Zero v1.0 Universal
1.5k stars 213 forks source link

layouts.all.all instead of layouts.all? #455

Closed dpieri closed 3 years ago

dpieri commented 5 years ago

I'm using version 6.1.0 within an app written in Coffeescript.

The documentation indicates that you can iterate through maki.layouts.all but in my experience maki.layouts.all is an object with a key all, so to iterate through the icons you need to access maki.layouts.all.all.

Is this something specific to my coffeescript setup, or does the documentation need to be updated?

maki = require '@mapbox/maki'

maki.layouts.all # { all: [...] }
maki.layouts.all.all # [...]
tristen commented 5 years ago

Thanks for the issue! This looks like something that should be solved from the exported reference over a doc update. Submitted a PR in #457 to address this 👍

dpieri commented 5 years ago

Is this going to bump the major version from 6 to 7?

tristen commented 5 years ago

Is this going to bump the major version from 6 to 7?

@dpieri that's correct.

tristen commented 3 years ago

Will be closed in the next release by #457