Update library icon - Githubissues

mapbox / maki

A POI Icon Set

http://labs.mapbox.com/maki-icons/

Creative Commons Zero v1.0 Universal

1.5k stars 213 forks source link

Update library icon #511

Closed vknoppkewetzel closed 3 years ago

vknoppkewetzel commented 3 years ago

Closes #504

Test style here

vknoppkewetzel commented 3 years ago

I removed -11 when I just updated the other tickets, which I believe is causing this to fail at the moment (but will be fine once we update requirements). Let me know if I should add -11 back in.

tristen commented 3 years ago

@vknoppkewetzel size adjustments look great! Just a couple points of feedback:

Line up nodes to the pixel grid	Simplify some detail
I see some nodes that could be either be adjusted to the nearest pixel or 0.5 pixel.	At higher resolution, some nodes that break up the arc look a tad awkward. I'm seeing a couple places where it might be worth removing nodes and just rely on the arcs?

vknoppkewetzel commented 3 years ago

Thanks @tristen done!

For the grid alignment, I utilized "snap to grid" and snapped corners to grids (via highlighted the x # of nodes for each corner), and then turned snap off and moved 0.5 pixel for the ones that were applicable across the icon. Some are aligned to exact grid line

Let me know if this looks better to you. I made sure to move based on cluster of nodes as I wanted to make sure the angle relationship stayed the same.

tristen commented 3 years ago

yay! @vknoppkewetzel just one small nitpicky change: Can you pull these nodes down to the nearest 1 or 0.5 pixel?

I did that quickly in Figma here:

And I think it results in a more pronounced curve and crisper line at 100% resolution.

vknoppkewetzel commented 3 years ago

Thanks @tristen ! updated ✅