Closed vknoppkewetzel closed 3 years ago
👋 @tristen would you mind taking a look at this PR this week? also can reassign!
@vknoppkewetzel I'm not seeing the icon in the test style. Unless I should be looking at different coordinates?
@tristen hrm thanks for pointing that out I had chosen Seattle as a location but looks like I did not save the copy-paste of the Seattle coordinates. It's updated now.
also have updated each ticket re: checklist, and will double check the checklists and ✅ things off today, to have them all ready for review ✨
@tristen thank you for this feedback! The ferry icon has been updated. I decided to make an exception with the 2px trim area in order to still allow this icon to have height and look less "fat", let me know if that looks alright.
test style also has been updated
Hey @tristen, I have updated the anchor coordinate angle, thank you!
@vknoppkewetzel anchor points look nice! Thoughts on making this a tad smaller/within the trim area? viewing this icon alongside monument, it's a little tall+wide
@tristen definitely, with the changes with monument this also looks less similar. will align it better and update accordingly after meetings 🙏
Hey @tristen the test style and icon have been updated, let me know what you think
@vknoppkewetzel ahh one small minor thing. What do you think about making it just 1px taller?
@tristen yes, np, done!
Description of change
Add localized ferry icon for Japan
Inspiration:
icons look like:
Link to demonstration
test style here
Closes #508
For author
HEAD
tag inCHANGELOG.md
For reviewer