mapbox / maki

A POI Icon Set
http://labs.mapbox.com/maki-icons/
Creative Commons Zero v1.0 Universal
1.5k stars 213 forks source link

add lighthouse-JP #516

Closed vknoppkewetzel closed 3 years ago

vknoppkewetzel commented 3 years ago

Description of change

Add localized lighthouse icon for Japan

inspiration:

Screen Shot 2021-03-03 at 4 05 56 PM

new icon:

Screen Shot 2021-04-14 at 10 25 27 AM

Link to demonstration

test style here


Closes #507

For author

For reviewer

vknoppkewetzel commented 3 years ago

updates, Working on updating this to rounded corner version

Screen Shot 2021-04-13 at 4 59 03 PM
vknoppkewetzel commented 3 years ago
Screen Shot 2021-04-14 at 10 25 27 AM

Did some reworking of it, when looking at the Maki Editor again, I noticed the religious-buddhist icon is a similar shape so I used that as a starting template instead

vknoppkewetzel commented 3 years ago

Hey @tristen, this PR is now g2g for review with the new template ✨

tristen commented 3 years ago

@vknoppkewetzel thoughts on increasing the points sticking out? They read pretty thin on the map:

Screen Shot 2021-04-14 at 12 08 00 PM

If they are supposed to communicate light casting out from the circle it might make sense to bring them out to the nearest pixel:

Screen Shot 2021-04-14 at 12 10 03 PM
vknoppkewetzel commented 3 years ago

Great idea @tristen ! Have adjusted accordingly

Screen Shot 2021-04-16 at 11 32 43 AM

to Screen Shot 2021-04-16 at 11 32 56 AM

vknoppkewetzel commented 3 years ago

that's @tristen a good point it does look like a ship's steering wheel. I had initially made the circle smaller but worried the inner circle got lost a little, however i can go back to that and play with it.

Happy to align not with a 0.5 pixel, and missed that imperfection.

Will address after meetings, thanks so much for this detailed feedback. All of this across these symbols is helping me get a little more practice in my symbol-detail-analysis, I really appreciate the detailed feedback. 🙏

tristen commented 3 years ago

I had initially made the circle smaller but worried the inner circle got lost a little, however i can go back to that and play with it.

Yeah, the inner circle has pretty good proportions. Maybe the outer ring?

vknoppkewetzel commented 3 years ago

@tristen yeah! I meant I had initially made the outer ring take up a smaller extent as well, but I will play around with it some more, ty! It's good to get feedback on this one, I had a few iterations that I wasn't fully happy with so it's good to hear thoughts on it.

vknoppkewetzel commented 3 years ago

👋 @tristen I have adjusted the icon, let me know if this looks good! test style updated

vknoppkewetzel commented 3 years ago

@tristen gosh idk why that happens, this must relate to how the SVG saved decimal-wise. I have suspected Adobe Illustrator doesn't always preserve recent SVG save settings and this happening 2x times makes it confirmed so i will make sure to go through the full "Save As" in the future rather than just "Save"

Tysm for flagging!