Closed vknoppkewetzel closed 3 years ago
updates, Working on updating this to rounded corner version
Did some reworking of it, when looking at the Maki Editor again, I noticed the religious-buddhist
icon is a similar shape so I used that as a starting template instead
Hey @tristen, this PR is now g2g for review with the new template ✨
@vknoppkewetzel thoughts on increasing the points sticking out? They read pretty thin on the map:
If they are supposed to communicate light casting out from the circle it might make sense to bring them out to the nearest pixel:
Great idea @tristen ! Have adjusted accordingly
to
that's @tristen a good point it does look like a ship's steering wheel. I had initially made the circle smaller but worried the inner circle got lost a little, however i can go back to that and play with it.
Happy to align not with a 0.5 pixel, and missed that imperfection.
Will address after meetings, thanks so much for this detailed feedback. All of this across these symbols is helping me get a little more practice in my symbol-detail-analysis, I really appreciate the detailed feedback. 🙏
I had initially made the circle smaller but worried the inner circle got lost a little, however i can go back to that and play with it.
Yeah, the inner circle has pretty good proportions. Maybe the outer ring?
@tristen yeah! I meant I had initially made the outer ring take up a smaller extent as well, but I will play around with it some more, ty! It's good to get feedback on this one, I had a few iterations that I wasn't fully happy with so it's good to hear thoughts on it.
👋 @tristen I have adjusted the icon, let me know if this looks good! test style updated
@tristen gosh idk why that happens, this must relate to how the SVG saved decimal-wise. I have suspected Adobe Illustrator doesn't always preserve recent SVG save settings and this happening 2x times makes it confirmed so i will make sure to go through the full "Save As" in the future rather than just "Save"
Tysm for flagging!
Description of change
Add localized lighthouse icon for Japan
inspiration:
new icon:
Link to demonstration
test style here
Closes #507
For author
HEAD
tag inCHANGELOG.md
For reviewer