search

mapbox / maki

A POI Icon Set
http://labs.mapbox.com/maki-icons/
Creative Commons Zero v1.0 Universal
1.5k stars 213 forks source link

Pixel Use Consistency #518

Closed willymaps closed 3 years ago

willymaps commented 3 years ago

Issue

Some icons do not explicitly use px in their svg width and height attributes:

<svg version="1.1" id="baseball-15" xmlns="http://www.w3.org/2000/svg" width="15px" height="15px" viewBox="0 0 15 15">

<svg id="basketball-15" xmlns="http://www.w3.org/2000/svg" width="15" height="15" viewBox="0 0 15 15">

willymaps commented 3 years ago

@elifitch clarified that px is not required in the width/height attributes. That also matches the default settings when exporting from Illustrator. Suggest px should be removed from existing icons for consistency.

willymaps commented 3 years ago

Was updated in main