mapbox / maki

A POI Icon Set
http://labs.mapbox.com/maki-icons/
Creative Commons Zero v1.0 Universal
1.51k stars 214 forks source link

Add highway-rest-area #544

Closed melanieimfeld closed 3 years ago

melanieimfeld commented 3 years ago

Description of change

Adding a the highway-rest-area icon to maki-beta

Link to demonstration

LINK


Closes #466 .

For author

For reviewer

Additional comments for reviewer

As discussed in styles review, I started off with an option (see below) that adheres to the circular trim area and has a more "table-shaped" table. When placed in the map, the table and the base were very difficult to see.

First version Screen Shot 2021-04-29 at 5 19 05 PM

Because of readability, I abandoned the above in favor of a version 1) with a more abstract table, 2) exceeding the circular trim area. It does still seem pretty small to me, so I do wonder if even more abstraction is needed?

Selected version Screen Shot 2021-04-29 at 5 19 59 PM

tristen commented 3 years ago

Hmm @melanieimfeld I wonder if there's a balance between the first and selected versions? The square is reading as a park table to me and feels a bit disproportionate to the tree. I think there's room to increase the size of the icon slightly if space feels constrained to increase legibility? (it looks a little smaller than the other Maki icons currently)

melanieimfeld commented 3 years ago

Hmm @melanieimfeld I wonder if there's a balance between the first and selected versions? The square is reading as a park table to me and feels a bit disproportionate to the tree. I think there's room to increase the size of the icon slightly if space feels constrained to increase legibility? (it looks a little smaller than the other Maki icons currently)

thanks for the feedback @tristen, let me try to scale up the first version then! The T-shaped table was really hard to read, but maybe I can make it visible by substantially scaling up

melanieimfeld commented 3 years ago

@tristen @vknoppkewetzel I updated the icon by scaling the first version to fit within a bounding box of 13px (see screenshot below or map demo here) What do you think?

Screen Shot 2021-05-03 at 5 07 17 PM
tristen commented 3 years ago

@melanieimfeld these changes look great and extending some of the shapes outside the trim area makes sense to me 👍 I think there's some opportunity to draw some of these anchor points to the nearest pixel to increase legibility at smaller sizes:

Screen Shot 2021-05-04 at 9 14 44 AM

As example, compare the table vertical base (with anchor points on the nearest pixel) to the top of the table or tree trunk:

Screen Shot 2021-05-04 at 9 09 24 AM

More antialiasing is being applied which creates a bit of blurriness when the icon is rasterized.

melanieimfeld commented 3 years ago

@tristen I made some adjustments to the shapes to align to the pixel grid (Only the anchor points from the rounded tree corners are off grid, such that the outermost points touch the vertical pixel gridlines). Here's the map view too!

Screen Shot 2021-05-04 at 12 48 36 PM